[Interpreter] Add more bytecode definitions and add operand types.

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include "src/compiler.h"
 #include "src/compiler/interpreter-assembler.h"
 #include "src/factory.h"
 #include "src/interpreter/bytecodes.h"
@@ skipping 12 matching lines @@
 
 void Interpreter::Initialize(bool create_heap_objects) {
   DCHECK(FLAG_ignition);
   if (create_heap_objects) {
     Zone zone;
     HandleScope scope(isolate_);
     Handle<FixedArray> handler_table = isolate_->factory()->NewFixedArray(
         static_cast<int>(Bytecode::kLast) + 1, TENURED);
     isolate_->heap()->public_set_interpreter_table(*handler_table);
 
-#define GENERATE_CODE(Name, _)                                         \
-    {                                                                  \
-      compiler::InterpreterAssembler assembler(isolate_, &zone,        \
-                                               Bytecode::k##Name);     \
-      Do##Name(&assembler);                                            \
-      Handle<Code> code = assembler.GenerateCode();                    \
-      handler_table->set(static_cast<int>(Bytecode::k##Name), *code);  \
-    }
+#define GENERATE_CODE(Name, ...)                                    \
+  {                                                                 \
+    compiler::InterpreterAssembler assembler(isolate_, &zone,       \
+                                             Bytecode::k##Name);    \
+    Do##Name(&assembler);                                           \
+    Handle<Code> code = assembler.GenerateCode();                   \
+    handler_table->set(static_cast<int>(Bytecode::k##Name), *code); \
+  }
     BYTECODE_LIST(GENERATE_CODE)
 #undef GENERATE_CODE
   }
 }
 
 
+// LoadLiteral0 <dst>
+//
 // Load literal '0' into the register index specified by the bytecode's
 // argument.

[rmcilroy, 2015/07/28 08:58:12]

/s/the register index specified by the bytecode's argument/the destination
register

[oth, 2015/07/28 13:24:14]

Done.

 void Interpreter::DoLoadLiteral0(compiler::InterpreterAssembler* assembler) {
-  Node* register_index = __ BytecodeArg(0);
+  Node* register_index = __ BytecodeOperand(0);
   __ StoreRegister(__ NumberConstant(0), register_index);
   __ Dispatch();
 }
 
 
+// LoadSmi8 <dst>, <imm8>
+//
+// Load an 8-bit integer literal into destination register as a Smi.
+void Interpreter::DoLoadSmi8(compiler::InterpreterAssembler* assembler) {
+  UNIMPLEMENTED();

[rmcilroy, 2015/07/28 08:58:12]

nit - just make this //TODO(rmcilroy) Implement LoadSmi8 for now.

[oth, 2015/07/28 13:24:14]

Done.

+}
+
+
+// Return
+//
 // Return the value in register 0.
 void Interpreter::DoReturn(compiler::InterpreterAssembler* assembler) {
   // TODO(rmcilroy) Jump to exit trampoline.
 }
 
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8