Issue 1257503002: FX_BOOL not always 0 or 1 in CPDF_PageObjects::m_ParserState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257503002: FX_BOOL not always 0 or 1 in CPDF_PageObjects::m_ParserState (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

FX_BOOL not always 0 or 1 in CPDF_PageObjects::m_ParserState This fixes part of the failure encountered at 320b2313d198. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/90144588255a87dea9e261bd909f2eece31a97b9

Patch Set 2 : Dead Code. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -73 lines)			Patch
M	core/include/fpdfapi/fpdf_page.h	View	1	4 chunks	+12 lines, -35 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page.cpp	View	1	5 chunks	+18 lines, -20 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp	View	1	1 chunk	+0 lines, -16 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

For review. https://codereview.chromium.org/1257503002/diff/1/core/include/fpdfapi/fpdf_page.h File core/include/fpdfapi/fpdf_page.h (left): https://codereview.chromium.org/1257503002/diff/1/core/include/fpdfapi/fpdf_page.h#oldcode43 core/include/fpdfapi/fpdf_page.h:43: int GetParseState() const note: dead code.

5 years, 5 months ago (2015-07-23 21:00:41 UTC) #1

Lei Zhang

lgtm https://codereview.chromium.org/1257503002/diff/1/core/include/fpdfapi/fpdf_page.h File core/include/fpdfapi/fpdf_page.h (left): https://codereview.chromium.org/1257503002/diff/1/core/include/fpdfapi/fpdf_page.h#oldcode53 core/include/fpdfapi/fpdf_page.h:53: int EstimateParseProgress() const; Also dead, along with CPDF_ContentParser::EstimateProgress(), ...

5 years, 5 months ago (2015-07-23 21:08:59 UTC) #2

Tom Sepez

5 years, 5 months ago (2015-07-23 21:36:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
90144588255a87dea9e261bd909f2eece31a97b9 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1257503002: FX_BOOL not always 0 or 1 in CPDF_PageObjects::m_ParserState (Closed)

Description

Patch Set 1 #

Patch Set 2 : Dead Code. #

Messages