Dump stats of memory pages which are hooked, but absent from /proc/<pid>/maps.

Dump stats of memory pages which are hooked, but absent from /proc/<pid>/maps.

BUG=189114
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188272

[Dai Mikurube (NOT FULLTIME), 2013-03-13 04:28:20]

Hi glider,

Could you take a look at this when you have time?  It should be landed after
https://codereview.chromium.org/12388070/.


willchan,

I just cc'd you (not as a reviewer) fyi since it changes only DMP files which
doesn't affect normal execution.

DMP code (deep-heap-profile) is carefully split from the main code not to affect
any execution without a request to use DMP.

[Alexander Potapenko, 2013-03-13 13:03:19]

LGTM with nit.

https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dm...
File tools/deep_memory_profiler/dmprof.py (right):

https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dm...
tools/deep_memory_profiler/dmprof.py:987: 'absent': 'absent_committed',
I wonder if you can make this map global and use that map's keys() instead of
global_stat_names in _parse_global_stats() above. This way there'll be a single
point where you'll need to add a new global stat in this file.

[Dai Mikurube (NOT FULLTIME), 2013-03-14 11:26:22]

Thank you, Alexander.

https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dm...
File tools/deep_memory_profiler/dmprof.py (right):

https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dm...
tools/deep_memory_profiler/dmprof.py:987: 'absent': 'absent_committed',
On 2013/03/13 13:03:19, Alexander Potapenko wrote:
> I wonder if you can make this map global and use that map's keys() instead of
> global_stat_names in _parse_global_stats() above. This way there'll be a
single
> point where you'll need to add a new global stat in this file.

Yeah, I actually would like to do it, but it actually depends on the order of
global_stat_names.

I think about fixing the dependency, but it would be done in another change
since it needs more change.

[willchan no longer on Chromium, 2013-03-14 16:17:54]

LGTM, I only looked at the tcmalloc code and not the tools code.

[Dai Mikurube (NOT FULLTIME), 2013-03-15 01:02:47]

Thanks, Alexander and Will.

Committing.

[commit-bot: I haz the power, 2013-03-15 01:08:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/12575008/1

[commit-bot: I haz the power, 2013-03-15 02:53:35]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-15 04:23:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/12575008/1

[commit-bot: I haz the power, 2013-03-15 07:07:21]

Change committed as 188272