Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 12575006: Merge 145319 (Closed)

Created:
7 years, 6 months ago by scherkus (not reviewing)
Modified:
7 years, 6 months ago
Reviewers:
ddorwin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145319 > [chromium] Set the Helper Plugin's URL to that of the host document. > https://bugs.webkit.org/show_bug.cgi?id=111913 > > This allows content settings, etc. to be based on the document hosting > the element that requested the Helper Plugin. > > Patch by David Dorwin <ddorwin@chromium.org>; on 2013-03-09 > Reviewed by Adam Barth. > > * src/WebHelperPluginImpl.cpp: > (WebKit::writeDocument): > (WebKit::WebHelperPluginImpl::initialize): > (WebKit::WebHelperPluginImpl::initializePage): > * src/WebHelperPluginImpl.h: > (WebKit): > (WebHelperPluginImpl): > * src/WebMediaPlayerClientImpl.cpp: > (WebKit::WebMediaPlayerClientImpl::createHelperPlugin): > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::createHelperPlugin): > * src/WebViewImpl.h: > (WebViewImpl): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M Source/WebKit/chromium/src/WebHelperPluginImpl.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebHelperPluginImpl.cpp View 6 chunks +12 lines, -7 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
7 years, 6 months ago (2013-03-13 00:59:50 UTC) #1
scherkus (not reviewing)
7 years, 6 months ago (2013-03-13 01:00:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r145646.

Powered by Google App Engine
This is Rietveld 408576698