make BoxLayout use and respect GetHeightForWidth().

ui/views/layout/box_layout_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/layout/box_layout.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/views/view.h"
 
 namespace views {
 
 namespace {
 
 class StaticSizedView : public View {
  public:
   explicit StaticSizedView(const gfx::Size& size)
     : size_(size) {
   }
+  virtual ~StaticSizedView() {}
 
-  virtual gfx::Size GetPreferredSize() OVERRIDE{
+  virtual gfx::Size GetPreferredSize() OVERRIDE {
     return size_;
   }
 
  private:
   gfx::Size size_;
 };
 
+class ProportionallySizedView : public View {
+ public:
+  explicit ProportionallySizedView(int factor) : factor_(factor) {}
+  virtual ~ProportionallySizedView() {}
+
+  virtual int GetHeightForWidth(int w) OVERRIDE {
+    return w * factor_;
+  }
+
+ private:
+  // The multiplicative factor between width and height, i.e.
+  // height = width * factor_.
+  int factor_;
+};

[sky, 2013/03/13 14:03:03]

DISALLOW_...

[Evan Stade, 2013/03/13 23:49:56]

Done.

+
 class BoxLayoutTest : public testing::Test {
  public:
   virtual void SetUp() OVERRIDE {
     host_.reset(new View);
   }
 
   scoped_ptr<View> host_;
   scoped_ptr<BoxLayout> layout_;
 };
 
@@ skipping 86 matching lines @@
   View* v2 = new StaticSizedView(gfx::Size(10, 10));
   host_->AddChildView(v2);
   EXPECT_EQ(gfx::Size(60, 40), layout_->GetPreferredSize(host_.get()));
 
   host_->SetBounds(0, 0, 100, 40);
   layout_->Layout(host_.get());
   EXPECT_EQ(gfx::Rect(10, 10, 40, 20).ToString(), v1->bounds().ToString());
   EXPECT_EQ(gfx::Rect(60, 10, 30, 20).ToString(), v2->bounds().ToString());
 }
 
+TEST_F(BoxLayoutTest, UseHeightForWidth) {
+  layout_.reset(new BoxLayout(BoxLayout::kVertical, 0, 0, 0));
+  View* v1 = new StaticSizedView(gfx::Size(20, 10));
+  host_->AddChildView(v1);
+  View* v2 = new ProportionallySizedView(2);
+  host_->AddChildView(v2);
+  EXPECT_EQ(gfx::Size(20, 50), layout_->GetPreferredSize(host_.get()));
+
+  host_->SetBounds(0, 0, 20, 50);
+  layout_->Layout(host_.get());
+  EXPECT_EQ(gfx::Rect(0, 0, 20, 10), v1->bounds());
+  EXPECT_EQ(gfx::Rect(0, 10, 20, 40), v2->bounds());
+}
+
 }  // namespace views