Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 125733003: [SyncFS] Clean up V1 drive_file_sync_util.h dependency from V2 (Closed)

Created:
6 years, 11 months ago by tzik
Modified:
6 years, 11 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Clean up V1 drive_file_sync_util.h dependency from V2 BUG=331991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243309

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -80 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 2 chunks +68 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/uninstall_app_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_util.cc View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tzik
PTL
6 years, 11 months ago (2014-01-07 05:50:02 UTC) #1
nhiroki
lgtm https://codereview.chromium.org/125733003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h File chrome/browser/sync_file_system/drive_backend/drive_backend_util.h (right): https://codereview.chromium.org/125733003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h#newcode61 chrome/browser/sync_file_system/drive_backend/drive_backend_util.h:61: // Translates GDataErrorCode to SyncStatusCode. nit: This comment ...
6 years, 11 months ago (2014-01-07 06:55:04 UTC) #2
kinuko
lgtm
6 years, 11 months ago (2014-01-07 09:42:17 UTC) #3
tzik
https://codereview.chromium.org/125733003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h File chrome/browser/sync_file_system/drive_backend/drive_backend_util.h (right): https://codereview.chromium.org/125733003/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_util.h#newcode61 chrome/browser/sync_file_system/drive_backend/drive_backend_util.h:61: // Translates GDataErrorCode to SyncStatusCode. On 2014/01/07 06:55:05, nhiroki ...
6 years, 11 months ago (2014-01-07 14:02:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/125733003/160001
6 years, 11 months ago (2014-01-07 14:02:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/125733003/160001
6 years, 11 months ago (2014-01-07 15:31:34 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 16:58:32 UTC) #7
Message was sent while issue was closed.
Change committed as 243309

Powered by Google App Engine
This is Rietveld 408576698