Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/google_input_tools/third_party/closure_library/closure/goog/events/eventtarget.js

Issue 1257313003: Update Google Input Tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Free up grd resources. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/google_input_tools/third_party/closure_library/closure/goog/events/eventtarget.js
diff --git a/third_party/google_input_tools/third_party/closure_library/closure/goog/events/eventtarget.js b/third_party/google_input_tools/third_party/closure_library/closure/goog/events/eventtarget.js
index 172c412da60e46811cdcd65157015db5935f9752..7408c7e09640ba54d9d639164a6de49e3c5e69d0 100644
--- a/third_party/google_input_tools/third_party/closure_library/closure/goog/events/eventtarget.js
+++ b/third_party/google_input_tools/third_party/closure_library/closure/goog/events/eventtarget.js
@@ -18,7 +18,6 @@
* {@code goog.events.Listenable}.
*
* @author arv@google.com (Erik Arvidsson) [Original implementation]
- * @author pupius@google.com (Daniel Pupius) [Port to use goog.events]
* @see ../demos/eventtarget.html
* @see goog.events.Listenable
*/
@@ -86,7 +85,7 @@ goog.events.EventTarget = function() {
/**
* Parent event target, used during event bubbling.
*
- * TODO(user): Change this to goog.events.Listenable. This
+ * TODO(chrishenry): Change this to goog.events.Listenable. This
* currently breaks people who expect getParentEventTarget to return
* goog.events.EventTarget.
*
@@ -248,7 +247,7 @@ goog.events.EventTarget.prototype.unlistenByKey = function(key) {
/** @override */
goog.events.EventTarget.prototype.removeAllListeners = function(opt_type) {
- // TODO(user): Previously, removeAllListeners can be called on
+ // TODO(chrishenry): Previously, removeAllListeners can be called on
// uninitialized EventTarget, so we preserve that behavior. We
// should remove this when usages that rely on that fact are purged.
if (!this.eventTargetListeners_) {
@@ -261,7 +260,7 @@ goog.events.EventTarget.prototype.removeAllListeners = function(opt_type) {
/** @override */
goog.events.EventTarget.prototype.fireListeners = function(
type, capture, eventObject) {
- // TODO(user): Original code avoids array creation when there
+ // TODO(chrishenry): Original code avoids array creation when there
// is no listener, so we do the same. If this optimization turns
// out to be not required, we can replace this with
// getListeners(type, capture) instead, which is simpler.
@@ -340,7 +339,7 @@ goog.events.EventTarget.prototype.assertInitialized_ = function() {
*
* @param {!Object} target The target to dispatch on.
* @param {goog.events.Event|Object|string} e The event object.
- * @param {Array.<goog.events.Listenable>=} opt_ancestorsTree The ancestors
+ * @param {Array<goog.events.Listenable>=} opt_ancestorsTree The ancestors
* tree of the target, in reverse order from the closest ancestor
* to the root event target. May be null if the target has no ancestor.
* @return {boolean} If anyone called preventDefault on the event object (or

Powered by Google App Engine
This is Rietveld 408576698