third_party/google_input_tools/src/chrome/os/inputview/elements/element.js - Issue 1257313003: Update Google Input Tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/elements/element.js

Issue 1257313003: Update Google Input Tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Free up grd resources. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/google_input_tools/src/chrome/os/inputview/elements/content/tabbarkey.js ('k') | third_party/google_input_tools/src/chrome/os/inputview/elements/elementtype.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/google_input_tools/src/chrome/os/inputview/elements/element.js

diff --git a/third_party/google_input_tools/src/chrome/os/inputview/elements/element.js b/third_party/google_input_tools/src/chrome/os/inputview/elements/element.js

index 467b59694fa08752ee218a2ceef11c807a490521..48e7f8ba9bf325e65273e8175d70d6cd2bc20785 100644

--- a/third_party/google_input_tools/src/chrome/os/inputview/elements/element.js

+++ b/third_party/google_input_tools/src/chrome/os/inputview/elements/element.js

@@ -142,7 +142,10 @@ Element.prototype.isVisible = function() {

* @param {boolean} visibility True if the element is visible.

Element.prototype.setVisible = function(visibility) {

- this.getElement().style.display = visibility ? this.display_ : 'none';

+ // TODO: Figure out why element can be null.

+ var element = this.getElement();

+ if (element)

+ element.style.display = visibility ? this.display_ : 'none';

};