Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/IceSwitchLowering.h

Issue 1257283004: Iasm and obj lowering for advanced switch lowering. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceSwitchLowering.h
diff --git a/src/IceSwitchLowering.h b/src/IceSwitchLowering.h
index 5dfcec3d630d71bedb4bc70628d110666ac546b3..7c3ed2c565b267392db2ac3ac816e91360ac5799 100644
--- a/src/IceSwitchLowering.h
+++ b/src/IceSwitchLowering.h
@@ -14,12 +14,15 @@
#ifndef SUBZERO_SRC_ICESWITCHLOWERING_H
#define SUBZERO_SRC_ICESWITCHLOWERING_H
-#include "IceCfgNode.h"
-#include "IceInst.h"
+#include "IceDefs.h"
namespace Ice {
class CaseCluster;
+class Cfg;
Jim Stichnoth 2015/07/30 15:20:24 At least Cfg and CfgNode forward declarations shou
ascull 2015/07/30 17:29:59 Done.
+class CfgNode;
+class InstJumpTable;
+class InstSwitch;
typedef std::vector<CaseCluster, CfgLocalAllocator<CaseCluster>>
CaseClusterArray;
@@ -38,8 +41,8 @@ public:
CaseCluster &operator=(const CaseCluster &) = default;
/// Create a cluster of a single case represented by a unitary range.
- CaseCluster(uint64_t Value, CfgNode *Label)
- : Kind(Range), Low(Value), High(Value), Label(Label) {}
+ CaseCluster(uint64_t Value, CfgNode *Target)
+ : Kind(Range), Low(Value), High(Value), Target(Target) {}
/// Create a case consisting of a jump table.
CaseCluster(uint64_t Low, uint64_t High, InstJumpTable *JT)
: Kind(JumpTable), Low(Low), High(High), JT(JT) {}
@@ -47,15 +50,18 @@ public:
CaseClusterKind getKind() const { return Kind; }
uint64_t getLow() const { return Low; }
uint64_t getHigh() const { return High; }
- CfgNode *getLabel() const {
+ CfgNode *getTarget() const {
assert(Kind == Range);
- return Label;
+ return Target;
}
InstJumpTable *getJumpTable() const {
assert(Kind == JumpTable);
return JT;
}
+ bool isUnitRange() const { return Low == High; }
+ bool isPairRange() const { return Low == High - 1; }
+
/// Discover cases which can be clustered together and return the clusters
/// ordered by case value.
static CaseClusterArray clusterizeSwitch(Cfg *Func, const InstSwitch *Inst);
@@ -65,7 +71,7 @@ private:
uint64_t Low;
uint64_t High;
union {
- CfgNode *Label; /// Target for a range.
+ CfgNode *Target; /// Target for a range.
InstJumpTable *JT; /// Jump table targets.
};
@@ -73,6 +79,34 @@ private:
bool tryAppend(const CaseCluster &New);
};
+/// Store the jump table data so that it can be emitted later in the correct
+/// ELF section once the offsets from the start of the function are known.
+class JumpTableData {
+ JumpTableData() = delete;
+ JumpTableData(const JumpTableData &) = delete;
+ JumpTableData &operator=(const JumpTableData &) = delete;
+
+public:
+ JumpTableData(IceString FuncName, SizeT Id, SizeT NumTargets)
+ : FuncName(FuncName), Id(Id) {
+ TargetOffsets.reserve(NumTargets);
+ }
+ JumpTableData(JumpTableData &&) = default;
+
+ void pushTarget(intptr_t Offset) { TargetOffsets.emplace_back(Offset); }
+
+ const IceString &getFunctionName() const { return FuncName; }
+ SizeT getId() const { return Id; }
+ const std::vector<intptr_t> &getTargetOffsets() const {
+ return TargetOffsets;
+ }
+
+private:
+ const IceString FuncName;
+ const SizeT Id;
+ std::vector<intptr_t> TargetOffsets;
+};
+
} // end of namespace Ice
#endif // SUBZERO_SRC_ICESWITCHLOWERING_H

Powered by Google App Engine
This is Rietveld 408576698