Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1257253005: Move strike to subrun in GrAtlasTextContext (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : feedback inc #

Patch Set 3 : tweaks #

Patch Set 4 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M src/gpu/GrAtlasTextBlob.h View 1 2 3 3 chunks +14 lines, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 7 chunks +12 lines, -7 lines 0 comments Download
M src/gpu/GrBatchAtlas.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
ptal
5 years, 4 months ago (2015-07-31 20:47:42 UTC) #2
bsalomon
lgtm
5 years, 4 months ago (2015-07-31 20:50:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257253005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257253005/40001
5 years, 4 months ago (2015-07-31 20:51:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/77d89f7dd243a17452d3a5f16a98622993e6bdd9
5 years, 4 months ago (2015-07-31 20:58:30 UTC) #6
joshualitt
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1266253002/ by joshualitt@google.com. ...
5 years, 4 months ago (2015-07-31 21:07:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257253005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257253005/60001
5 years, 4 months ago (2015-07-31 22:10:45 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 22:18:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7e97b0bad0d80901a19922323343a19d69f34b0b

Powered by Google App Engine
This is Rietveld 408576698