Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: Source/core/html/HTMLCanvasElement.h

Issue 1257253004: [HTMLCanvasElement.toBlob] Default callback version without scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Basic Callback version of toBlob function of HTMLCanvasElement Implemented Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLCanvasElement.h
diff --git a/Source/core/html/HTMLCanvasElement.h b/Source/core/html/HTMLCanvasElement.h
index 29dad69ba21f9cc0379eaa21318fc9c1216b0522..55f2bbdad5427adb70f32c1da813dd67adba56af 100644
--- a/Source/core/html/HTMLCanvasElement.h
+++ b/Source/core/html/HTMLCanvasElement.h
@@ -35,6 +35,7 @@
#include "core/dom/DocumentVisibilityObserver.h"
#include "core/html/HTMLElement.h"
#include "core/html/canvas/CanvasImageSource.h"
+#include "modules/filesystem/FileCallback.h"
#include "platform/geometry/FloatRect.h"
#include "platform/geometry/IntSize.h"
#include "platform/graphics/GraphicsTypes.h"
@@ -113,6 +114,9 @@ public:
String toDataURL(const String& mimeType, const ScriptValue& qualityArgument, ExceptionState&) const;
String toDataURL(const String& mimeType, ExceptionState& exceptionState) const { return toDataURL(mimeType, ScriptValue(), exceptionState); }
+ void toBlob(FileCallback*, const String& mimeType, const ScriptValue& qualityArgument, ExceptionState&) const;
Justin Novosad 2015/08/13 21:03:40 This new entry point is not tested
xlai (Olivia) 2015/08/20 19:46:44 Acknowledged. Planning to write another Layout tes
+ void toBlob(FileCallback* callback, const String& mimeType, ExceptionState& exceptionState) { return toBlob(callback, mimeType, ScriptValue(), exceptionState); }
+
// Used for rendering
void didDraw(const FloatRect&);
void notifyObserversCanvasChanged(const FloatRect&);
@@ -185,6 +189,7 @@ private:
using ContextFactoryVector = Vector<OwnPtr<CanvasRenderingContextFactory>>;
static ContextFactoryVector& renderingContextFactories();
static CanvasRenderingContextFactory* getRenderingContextFactory(int);
+
Justin Novosad 2015/08/13 21:03:40 spurious new line
xlai (Olivia) 2015/08/20 19:46:44 Done.
void parseAttribute(const QualifiedName&, const AtomicString&) override;
LayoutObject* createLayoutObject(const ComputedStyle&) override;

Powered by Google App Engine
This is Rietveld 408576698