LayoutTests/fast/canvas/canvas-toBlob-defaultpng.html - Issue 1257253004: [HTMLCanvasElement.toBlob] Default callback version without scheduler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/canvas/canvas-toBlob-defaultpng.html

Issue 1257253004: [HTMLCanvasElement.toBlob] Default callback version without scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Basic Callback version of toBlob function of HTMLCanvasElement Implemented Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <script src = "../../resources/js-test.js"></ script>

	3 <script type = 'text/javascript'>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6

	7 canvas = document.createElement("canvas");
	Justin Novosad 2015/08/13 21:03:40 var canvas var canvas xlai (Olivia) 2015/08/20 19:46:43 Done for this and elsewhere. Show quoted text On 2015/08/13 21:03:40, Justin Novosad wrote: > var canvas Done for this and elsewhere.
	8 var ctx = canvas.getContext("2d");

	9 ctx.fillStyle = "#FF0000";

	10 ctx.fillRect(0, 0, 150, 75);

	11

	12 canvas.toBlob(function(blob) {

	13 var newImg = document.createElement("img"),
	Justin Novosad 2015/08/13 21:03:40 , -> ; , -> ;
	14 url = URL.createObjectURL(blob);
	Justin Novosad 2015/08/13 21:03:39 indentation indentation
	15 newImg.onload = function()

	16 {

	17 // no longer need to read the blob so it's revoked

	18 URL.revokeObjectURL(url);
	Justin Novosad 2015/08/13 21:03:40 This will not be called because the test finishes This will not be called because the test finishes too early.
	19 };

	20 newImg.src = url;

	21 document.body.appendChild(newImg);

	22 });

	23

	24 function tryGetImageTag()

	25 {

	26 var tags = document.getElementsByTagName('img');
	Justin Novosad 2015/08/13 21:03:40 you should just make newImg global and use it dire you should just make newImg global and use it directly here. The checks below would be unnecessary.
	27 if (typeof tags == = "undefined")

	28 return "";

	29 else if (typeof tags[0] == = "undefined")

	30 return "";

	31 else

	32 return tags[0].src.substring(0, 9);

	33 }

	34

	35 shouldBecomeEqual("tryGetImageTag()", "'blob:null'", function(){}, 1000);
	Justin Novosad 2015/08/13 21:03:40 Can you explain what exactly this tests, why is th Can you explain what exactly this tests, why is this asynchronous? Also, this test doe not verify that toBlob worked as far as I can tell.
	36

	37 if (window.testRunner)

	38 testRunner.notifyDone();
	Justin Novosad 2015/08/13 21:03:39 This belongs in the shouldBecomeEqual completion h This belongs in the shouldBecomeEqual completion handler. IF it works like this, you probably don't need the test to be async in the first place. Also, you are missing the mating call to waitUntilDone() xlai (Olivia) 2015/08/20 19:46:43 Deleted this. Changed the shouldBecomeEqual to sho Show quoted text On 2015/08/13 21:03:39, Justin Novosad wrote: > This belongs in the shouldBecomeEqual completion handler. IF it works like this, > you probably don't need the test to be async in the first place. Also, you are > missing the mating call to waitUntilDone() Deleted this. Changed the shouldBecomeEqual to shouldBe function. Remove unnecessary checks about img tag.
	39 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/canvas/canvas-toBlob-defaultpng-expected.txt » ('j') | Source/core/fileapi/File.h » ('J')