LayoutTests/http/tests/security/canvas-read-blocked-by-setting.html - Issue 1257253004: [HTMLCanvasElement.toBlob] Default callback version without scheduler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/canvas-read-blocked-by-setting.html

Issue 1257253004: [HTMLCanvasElement.toBlob] Default callback version without scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changes based on second code reviews 2 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/canvas/canvas-toBlob-defaultpng.html ('K') | « LayoutTests/fast/canvas/canvas-toBlob-webp-maximum-quality-expected.txt ('k') | LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-maximum-quality-expected.png » ('j') | Source/core/fileapi/File.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Block reading canvas via StrictCanvasTainting setting</title>	2 <title>Block reading canvas via StrictCanvasTainting setting</title>

3 <script src="/resources/testharness.js"></script>	3 <script src="/resources/testharness.js"></script>

4 <script src="/resources/testharnessreport.js"></script>	4 <script src="/resources/testharnessreport.js"></script>

5 <script>	5 <script>

6 if (window.testRunner)	6 if (window.testRunner)

7 testRunner.overridePreference("WebKitDisableReadingFromCanvas", true);	7 testRunner.overridePreference("WebKitDisableReadingFromCanvas", true);

8	8

9 var image = new Image();	9 var image = new Image();

10 var canvas = document.createElement('canvas');	10 var canvas = document.createElement('canvas');

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42	42

43 test(function () {	43 test(function () {

44 assert_throws(	44 assert_throws(

45 "SecurityError",	45 "SecurityError",

46 function() {	46 function() {

47 context.drawImage(image, 0, 0, 100, 100);	47 context.drawImage(image, 0, 0, 100, 100);

48 var data_url = canvas.toDataURL();	48 var data_url = canvas.toDataURL();

49 assert_unreached('toDataURL should throw');	49 assert_unreached('toDataURL should throw');

50 });	50 });

51 }, 'toDataURL');	51 }, 'toDataURL');

	52

	53 test(function () {
	xlai (Olivia) 2015/08/21 18:40:06 security error test for toBlob function added; thi security error test for toBlob function added; this is same as toDataURL.
	54 assert_throws(

	55 "SecurityError",

	56 function() {

	57 context.drawImage(image, 0, 0, 100, 100);

	58 canvas.toBlob(function(blob){});

	59 assert_unreached('toBlob should throw');

	60 });

	61 }, 'toBlob');

52 </script>	62 </script>

OLD	NEW