Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1257243002: Fix document mode promo ImageView height. (Closed)

Created:
5 years, 4 months ago by aurimas (slooooooooow)
Modified:
5 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix document mode promo ImageView height. On certain small devices the height of the ImageView did not adjust after the image got scaled. Set adjustViewBounds to true to start adjusting the height. BUG=514319 Committed: https://crrev.com/d2fe9d743717aa080b6fec31f4bf7d3beb8d9506 Cr-Commit-Position: refs/heads/master@{#340615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/res/layout/opt_out_promo.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 4 months ago (2015-07-27 23:35:29 UTC) #2
newt (away)
lgtm
5 years, 4 months ago (2015-07-27 23:38:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257243002/1
5 years, 4 months ago (2015-07-27 23:39:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 00:17:28 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 00:17:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2fe9d743717aa080b6fec31f4bf7d3beb8d9506
Cr-Commit-Position: refs/heads/master@{#340615}

Powered by Google App Engine
This is Rietveld 408576698