Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1257233008: fix language_tests.js to use strict mode (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix language_tests.js to use strict mode we weren't running a bunch of tests on the bots :| amazingly, none were broken yet this also fixes karma.conf log level, and disables some spammy prints from one of the tests R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2d3e66ac12e440b0ad9734d7240228e705124c5d

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -182 lines) Patch
M karma.conf.js View 1 3 chunks +5 lines, -4 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +58 lines, -55 lines 0 comments Download
M test/codegen/expect/js_test.txt View 16 chunks +120 lines, -120 lines 0 comments Download
M test/codegen/language/async_throw_in_catch_test.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen/language/asyncstar_throw_in_catch_test.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tool/browser_test.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Jennifer Messerly
5 years, 4 months ago (2015-07-31 17:25:08 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/1257233008/diff/20001/test/browser/language_tests.js File test/browser/language_tests.js (left): https://codereview.chromium.org/1257233008/diff/20001/test/browser/language_tests.js#oldcode25 test/browser/language_tests.js:25: 'syncstar_yieldstart_test' note the typo. ouch!
5 years, 4 months ago (2015-07-31 17:53:06 UTC) #3
Jennifer Messerly
On 2015/07/31 17:53:06, John Messerly wrote: > https://codereview.chromium.org/1257233008/diff/20001/test/browser/language_tests.js > File test/browser/language_tests.js (left): > > https://codereview.chromium.org/1257233008/diff/20001/test/browser/language_tests.js#oldcode25 ...
5 years, 4 months ago (2015-08-03 20:50:05 UTC) #4
vsm
lgtm https://codereview.chromium.org/1257233008/diff/20001/test/codegen/language/async_throw_in_catch_test.dart File test/codegen/language/async_throw_in_catch_test.dart (right): https://codereview.chromium.org/1257233008/diff/20001/test/codegen/language/async_throw_in_catch_test.dart#newcode18 test/codegen/language/async_throw_in_catch_test.dart:18: //print("Tracing $name: $msg"); Maybe a comment here? Hmm ...
5 years, 4 months ago (2015-08-03 20:57:33 UTC) #5
Jennifer Messerly
https://codereview.chromium.org/1257233008/diff/20001/test/codegen/language/async_throw_in_catch_test.dart File test/codegen/language/async_throw_in_catch_test.dart (right): https://codereview.chromium.org/1257233008/diff/20001/test/codegen/language/async_throw_in_catch_test.dart#newcode18 test/codegen/language/async_throw_in_catch_test.dart:18: //print("Tracing $name: $msg"); On 2015/08/03 20:57:33, vsm wrote: > ...
5 years, 4 months ago (2015-08-03 21:08:11 UTC) #6
Jennifer Messerly
5 years, 4 months ago (2015-08-03 21:08:18 UTC) #7
Jennifer Messerly
5 years, 4 months ago (2015-08-03 21:08:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
2d3e66ac12e440b0ad9734d7240228e705124c5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698