Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1257233004: [SafeBrowsing] Consolidate extension lookup logic and extension lists. (Closed)

Created:
5 years, 4 months ago by asanka
Modified:
5 years, 4 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@double-zip
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SafeBrowsing] Consolidate extension lookup logic and extension lists. R=mattm@chromium.org,asvitkine@chromium.org BUG=none Committed: https://crrev.com/213f260fcc0582dbb4bd2ad1098300ceaf2b542c Cr-Commit-Position: refs/heads/master@{#341520}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix Windows unit test build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -185 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 1 1 chunk +9 lines, -99 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/safe_browsing/download_protection_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/download_protection_util.cc View 1 2 chunks +191 lines, -86 lines 0 comments Download
A chrome/common/safe_browsing/download_protection_util_unittest.cc View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1262753002 Patch 140001

Messages

Total messages: 18 (7 generated)
asanka
PTAL?
5 years, 4 months ago (2015-07-31 02:40:39 UTC) #1
Alexei Svitkine (slow)
histograms lgtm, didn't look at the cc
5 years, 4 months ago (2015-07-31 14:57:38 UTC) #2
mattm
nice cleanup, lgtm
5 years, 4 months ago (2015-07-31 20:31:40 UTC) #3
asanka
Thanks everyone! Will land after the dependent CL lands.
5 years, 4 months ago (2015-07-31 20:35:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257233004/20001
5 years, 4 months ago (2015-08-02 21:26:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/65860)
5 years, 4 months ago (2015-08-02 21:51:03 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257233004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257233004/40001
5 years, 4 months ago (2015-08-03 05:04:25 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-03 07:00:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257233004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257233004/40001
5 years, 4 months ago (2015-08-03 13:46:22 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-03 13:51:58 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 13:52:54 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/213f260fcc0582dbb4bd2ad1098300ceaf2b542c
Cr-Commit-Position: refs/heads/master@{#341520}

Powered by Google App Engine
This is Rietveld 408576698