src/heap/objects-visiting.cc - Issue 1257223002: Revert of Remove ExternalArray, derived types, and element kinds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting.cc

Issue 1257223002: Revert of Remove ExternalArray, derived types, and element kinds (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/objects-visiting.cc

diff --git a/src/heap/objects-visiting.cc b/src/heap/objects-visiting.cc

index 70f26a504a7f743de883094653103b9158fd4344..8de0da96210a472adc51cbf00071da6b6189c81d 100644

--- a/src/heap/objects-visiting.cc

+++ b/src/heap/objects-visiting.cc

@@ -139,8 +139,13 @@

case HEAP_NUMBER_TYPE:

case MUTABLE_HEAP_NUMBER_TYPE:

case FLOAT32X4_TYPE:

+#define EXTERNAL_ARRAY_CASE(Type, type, TYPE, ctype, size) \

+ case EXTERNAL_##TYPE##_ARRAY_TYPE:

+ TYPED_ARRAYS(EXTERNAL_ARRAY_CASE)

return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,

instance_size, has_unboxed_fields);

+#undef EXTERNAL_ARRAY_CASE

case FIXED_UINT8_ARRAY_TYPE:

case FIXED_INT8_ARRAY_TYPE:

« no previous file with comments | « src/heap/heap.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »