Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1257223002: Revert of Remove ExternalArray, derived types, and element kinds (Closed)

Created:
5 years, 4 months ago by Michael Achenbach
Modified:
5 years, 4 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove ExternalArray, derived types, and element kinds (patchset #5 id:80001 of https://codereview.chromium.org/1254623002/) Reason for revert: [Sheriff] Breaks several layout tests, e.g.: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/1067 Several output lines change from PASS to FAIL. If the changes are intended, please land a needsmanualrebaseline change in blink first. Original issue's description: > Remove ExternalArray, derived types, and element kinds > > BUG=v8:3996 > R=jarin@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org > LOG=y > > Committed: https://crrev.com/607ef7c6009a24ebf195b4cab7b0b436c5afd21c > Cr-Commit-Position: refs/heads/master@{#29872} TBR=bmeurer@chromium.org,hpayer@chromium.org,jarin@chromium.org,mvstanton@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2 Cr-Commit-Position: refs/heads/master@{#29883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1893 lines, -359 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 8 chunks +32 lines, -6 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +26 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +24 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 5 chunks +60 lines, -1 line 0 comments Download
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/contexts.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/elements.cc View 5 chunks +35 lines, -0 lines 0 comments Download
M src/elements-kind.h View 4 chunks +35 lines, -8 lines 0 comments Download
M src/elements-kind.cc View 4 chunks +39 lines, -6 lines 0 comments Download
M src/factory.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/factory.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/heap.h View 4 chunks +31 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +82 lines, -16 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +35 lines, -23 lines 0 comments Download
M src/hydrogen-instructions.h View 8 chunks +42 lines, -15 lines 0 comments Download
M src/hydrogen-instructions.cc View 6 chunks +15 lines, -9 lines 0 comments Download
M src/hydrogen-uint32-analysis.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +28 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +16 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ic/ic-compiler.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/lookup.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 9 chunks +32 lines, -6 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 9 chunks +32 lines, -6 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/objects.h View 10 chunks +315 lines, -6 lines 0 comments Download
M src/objects.cc View 23 chunks +191 lines, -22 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +14 lines, -6 lines 0 comments Download
M src/objects-inl.h View 9 chunks +255 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 17 chunks +32 lines, -6 lines 0 comments Download
M src/ppc/lithium-ppc.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/runtime/runtime-array.cc View 5 chunks +53 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +12 lines, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 5 chunks +23 lines, -14 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 5 chunks +28 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +16 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 6 chunks +28 lines, -6 lines 0 comments Download
M src/x87/lithium-x87.h View 3 chunks +16 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M test/mjsunit/elements-kind.js View 3 chunks +46 lines, -9 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 2 chunks +33 lines, -32 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 2 chunks +33 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Remove ExternalArray, derived types, and element kinds
5 years, 4 months ago (2015-07-27 20:31:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257223002/1
5 years, 4 months ago (2015-07-27 20:31:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 20:32:09 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 20:32:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/814048a04f667f4537ad80a3ae63d3699b4afdb2
Cr-Commit-Position: refs/heads/master@{#29883}

Powered by Google App Engine
This is Rietveld 408576698