Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/wtf/text/StringBuilderTest.cpp

Issue 1257203002: Fix ODR violation that can break WTF::String pretty printing in tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Really fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 15 matching lines...) Expand all
26 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 26 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30 */ 30 */
31 31
32 #include "config.h" 32 #include "config.h"
33 #include "wtf/text/StringBuilder.h" 33 #include "wtf/text/StringBuilder.h"
34 34
35 #include "wtf/Assertions.h" 35 #include "wtf/Assertions.h"
36 #include "wtf/testing/WTFTestHelpers.h"
37 #include "wtf/text/CString.h" 36 #include "wtf/text/CString.h"
38 #include "wtf/text/CharacterNames.h" 37 #include "wtf/text/CharacterNames.h"
39 #include "wtf/text/WTFString.h" 38 #include "wtf/text/WTFString.h"
40 #include <gtest/gtest.h> 39 #include <gtest/gtest.h>
41 40
42 namespace WTF { 41 namespace WTF {
43 42
44 namespace { 43 namespace {
45 44
46 void expectBuilderContent(const String& expected, const StringBuilder& builder) 45 void expectBuilderContent(const String& expected, const StringBuilder& builder)
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 StringBuilder reference; 318 StringBuilder reference;
320 reference.append(replacementCharacter); // Make it UTF-16. 319 reference.append(replacementCharacter); // Make it UTF-16.
321 reference.append(String::number(someNumber)); 320 reference.append(String::number(someNumber));
322 StringBuilder test; 321 StringBuilder test;
323 test.append(replacementCharacter); 322 test.append(replacementCharacter);
324 test.appendNumber(someNumber); 323 test.appendNumber(someNumber);
325 EXPECT_EQ(reference, test); 324 EXPECT_EQ(reference, test);
326 } 325 }
327 326
328 } // namespace WTF 327 } // namespace WTF
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698