Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: Source/wtf/testing/WTFTestPrintersTest.cpp

Issue 1257203002: Fix ODR violation that can break WTF::String pretty printing in tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Really fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 11 matching lines...) Expand all
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "wtf/testing/WTFTestHelpers.h"
33 32
34 #include "wtf/StdLibExtras.h" 33 #include "wtf/StdLibExtras.h"
35 #include "wtf/text/CString.h" 34 #include "wtf/text/CString.h"
36 #include "wtf/text/WTFString.h" 35 #include "wtf/text/WTFString.h"
37 #include <gtest/gtest.h> 36 #include <gtest/gtest.h>
38 #include <sstream> 37 #include <sstream>
39 #include <string> 38 #include <string>
40 39
41 using namespace WTF; 40 using namespace WTF;
42 41
(...skipping 19 matching lines...) Expand all
62 EXPECT_EQ(CString("\"\\u007F\\u0080\\u0081\""), toCStringThroughPrinter("\x7 F\x80\x81")); 61 EXPECT_EQ(CString("\"\\u007F\\u0080\\u0081\""), toCStringThroughPrinter("\x7 F\x80\x81"));
63 EXPECT_EQ(CString("\"\""), toCStringThroughPrinter(emptyString())); 62 EXPECT_EQ(CString("\"\""), toCStringThroughPrinter(emptyString()));
64 EXPECT_EQ(CString("<null>"), toCStringThroughPrinter(String())); 63 EXPECT_EQ(CString("<null>"), toCStringThroughPrinter(String()));
65 64
66 static const UChar unicodeSample[] = { 0x30C6, 0x30B9, 0x30C8 }; // "Test" i n Japanese. 65 static const UChar unicodeSample[] = { 0x30C6, 0x30B9, 0x30C8 }; // "Test" i n Japanese.
67 EXPECT_EQ(CString("\"\\u30C6\\u30B9\\u30C8\""), toCStringThroughPrinter(Stri ng(unicodeSample, WTF_ARRAY_LENGTH(unicodeSample)))); 66 EXPECT_EQ(CString("\"\\u30C6\\u30B9\\u30C8\""), toCStringThroughPrinter(Stri ng(unicodeSample, WTF_ARRAY_LENGTH(unicodeSample))));
68 67
69 } 68 }
70 69
71 } 70 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698