Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1257183003: PPC: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. Port cac64b9f634743f7f5311d4dca8d50157b10fab5 Original commit message: We don't need the hole check and slow runtime mode for read-only properties this way. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/a30ffc77e81349d5ae814f31646dbf2b113869ed Cr-Commit-Position: refs/heads/master@{#29882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/ppc/code-stubs-ppc.cc View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-27 19:32:23 UTC) #1
dstence
lgtm
5 years, 4 months ago (2015-07-27 19:45:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257183003/1
5 years, 4 months ago (2015-07-27 19:45:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 20:12:16 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 20:12:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a30ffc77e81349d5ae814f31646dbf2b113869ed
Cr-Commit-Position: refs/heads/master@{#29882}

Powered by Google App Engine
This is Rietveld 408576698