Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1257163002: Kill FX_READER_DLL symbol (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill FX_READER_DLL symbol It is never defined, and the declspec()s based on it appear inconsistently used. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fa69033db8803b191fa43f3c5bec65998d2dc2f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M fpdfsdk/include/fxedit/fx_edit.h View 3 chunks +2 lines, -12 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Button.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 2 chunks +2 lines, -11 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 4 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, more cleanup.
5 years, 4 months ago (2015-07-27 18:54:43 UTC) #1
Tom Sepez
Add reviewer.
5 years, 4 months ago (2015-07-27 19:23:58 UTC) #3
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-27 20:25:45 UTC) #4
Tom Sepez
5 years, 4 months ago (2015-07-27 21:25:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fa69033db8803b191fa43f3c5bec65998d2dc2f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698