Fix uaf in ApplicationInstance.

Fix uaf in ApplicationInstance.

Forward originator identity through to ApplicationInstance ctor so that it can be used to locate an originator when reconnecting.

R=sky@chromium.org
BUG=none

Committed: https://crrev.com/70929975574fdbc26b635141672e6fe070fa4ab9
Cr-Commit-Position: refs/heads/master@{#340555}

[sky, 2015-07-27 19:11:52]

LGTM

[Ben Goodger (Google), 2015-07-27 19:18:03]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2015-07-27 19:18:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1257133003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1257133003/1

[Ben Goodger (Google), 2015-07-27 19:26:34]

https://codereview.chromium.org/1257133003/diff/1/mojo/shell/application_inst...
File mojo/shell/application_instance.cc (right):

https://codereview.chromium.org/1257133003/diff/1/mojo/shell/application_inst...
mojo/shell/application_instance.cc:150:
manager->GetApplicationInstance(originator_identity_);
note to my future self: I am concerned that in its current form identity is
insufficient here, as |originator| as returned may differ from the instance that
spawned this instance. e.g.:

Instance1 is created for application identity "A,B" with a specific capability
filter CF1.
Instance1 connects to Instance2.
..
Instance1 is destroyed.
Instance3 is created for application identity "A,B" with specific capability
filter CF2 <-- note the difference.
Instance2 experiences a connection error and this code is reached.  It asks the
application manager for the instance corresponding to "A,B" and gets Instance3,
which has a different set of allowed interfaces than long-gone Instance1. Oops.

Ultimately I think CF should be part of the application identity.

[commit-bot: I haz the power, 2015-07-27 20:43:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-27 20:44:18]

Patchset 1 (id:??) landed as
https://crrev.com/70929975574fdbc26b635141672e6fe070fa4ab9
Cr-Commit-Position: refs/heads/master@{#340555}