compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java - Issue 12571002: Intern AST and Model names to reduce char[]/String waste.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java

Issue 12571002: Intern AST and Model names to reduce char[]/String waste. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/ast/DartStringLiteral.java ('k') | compiler/java/com/google/dart/compiler/util/StringInterner.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java b/compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java

index 50ec6a15c262d055529f1c802ff7bfe7b326ad63..2c5a703d15f6f252112a9dbf3514fbb892f4ab12 100644

--- a/compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java

+++ b/compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java

@@ -10,6 +10,7 @@ import com.google.dart.compiler.ast.Modifiers;

import com.google.dart.compiler.common.SourceInfo;

import com.google.dart.compiler.type.Type;

import com.google.dart.compiler.type.Types;

+import com.google.dart.compiler.util.StringInterner;

abstract class AbstractNodeElement implements Element, NodeElement {

private final DartNode node;

@@ -20,7 +21,7 @@ abstract class AbstractNodeElement implements Element, NodeElement {

// TODO(scheglov) in the future we will not use ASTNode and remove null check

this.sourceInfo = node != null ? node.getSourceInfo() : SourceInfo.UNKNOWN;

this.node = node;

- this.name = name;

+ this.name = StringInterner.intern(name);

}

@Override