editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java - Issue 12571002: Intern AST and Model names to reduce char[]/String waste.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java

Issue 12571002: Intern AST and Model names to reduce char[]/String waste. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartTypeParameterImpl.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/NamedTypeMemberImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java

index 2d6125dbb85299108e8c4a9c2d7a08caad5f03d4..c1907329124c1ef8f91c99b23cee2a0a93ae279d 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java

@@ -13,6 +13,7 @@

package com.google.dart.tools.core.internal.model;

+import com.google.dart.compiler.util.StringInterner;

import com.google.dart.tools.core.DartCore;

import com.google.dart.tools.core.internal.model.info.DartVariableInfo;

import com.google.dart.tools.core.internal.util.MementoTokenizer;

@@ -41,7 +42,7 @@ public class DartVariableImpl extends SourceReferenceImpl implements DartVariabl

public DartVariableImpl(DartElementImpl parent, String name) {

super(parent);

- this.name = name;

+ this.name = StringInterner.intern(name);

}

@Override