Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 1257063003: Add a --harmony-object-observe runtime flag (on by default) (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a --harmony-object-observe runtime flag (on by default) To avoid tanking context startup performance, only the actual installation of the JS-exposed API is flag-guarded. The remainder of the implementation still resides in the snapshot. Committed: https://crrev.com/2e4efcfac243268177dc34f4805cd2739d84dbd5 Cr-Commit-Position: refs/heads/master@{#30017}

Patch Set 1 #

Patch Set 2 : Merged #

Patch Set 3 : Move some initialization back to the snapshot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +1 line, -0 lines 0 comments Download
A + src/harmony-object-observe.js View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M src/object-observe.js View 1 2 2 chunks +20 lines, -8 lines 0 comments Download
M test/mjsunit/array-push7.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/debug-stepin-microtasks.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/microtask-delivery.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/regress/regress-3750.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es7/object-observe-debug-event.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es7/object-observe-runtime.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-405844.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-observe-empty-double-array.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/migrations.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-3315.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-356589.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-417709a.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-observe-map-cache.js View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
adamk
5 years, 4 months ago (2015-08-04 00:11:17 UTC) #2
rossberg
lgtm
5 years, 4 months ago (2015-08-04 12:44:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257063003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257063003/20001
5 years, 4 months ago (2015-08-04 18:08:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2984)
5 years, 4 months ago (2015-08-04 18:16:48 UTC) #8
adamk
Had to add some code to remove function prototypes during snapshot generation (assume this has ...
5 years, 4 months ago (2015-08-04 20:15:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257063003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257063003/40001
5 years, 4 months ago (2015-08-04 20:16:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-04 20:53:30 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 20:53:40 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e4efcfac243268177dc34f4805cd2739d84dbd5
Cr-Commit-Position: refs/heads/master@{#30017}

Powered by Google App Engine
This is Rietveld 408576698