Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: pkg/analyzer/test/instrumentation/instrumentation_test.dart

Issue 1257023003: Capture more data when instrumenting exceptions (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/instrumentation/instrumentation_test.dart
diff --git a/pkg/analyzer/test/instrumentation/instrumentation_test.dart b/pkg/analyzer/test/instrumentation/instrumentation_test.dart
index b1c263dd36b83f259d96f937292803466370b871..e23fd9ac70af618fd24b2f8fa10b1d9159fb3bb1 100644
--- a/pkg/analyzer/test/instrumentation/instrumentation_test.dart
+++ b/pkg/analyzer/test/instrumentation/instrumentation_test.dart
@@ -73,9 +73,12 @@ class InstrumentationServiceTest {
String level = 'level';
DateTime time = new DateTime(2001);
String message = 'message';
- service.logLogEntry(level, time, message);
+ String exception = 'exception';
+ String stackTraceText = 'stackTrace';
+ StackTrace stackTrace = new StackTrace.fromString(stackTraceText);
+ service.logLogEntry(level, time, message, exception, stackTrace);
assertNormal(server, InstrumentationService.TAG_LOG_ENTRY,
- '$level:${time.millisecondsSinceEpoch}:$message');
+ '$level:${time.millisecondsSinceEpoch}:$message:$exception:$stackTraceText');
}
void test_logNotification() {

Powered by Google App Engine
This is Rietveld 408576698