pkg/analysis_server/lib/src/analysis_logger.dart - Issue 1257023003: Capture more data when instrumenting exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/analysis_logger.dart

Issue 1257023003: Capture more data when instrumenting exceptions (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/analysis_logger.dart

diff --git a/pkg/analysis_server/lib/src/analysis_logger.dart b/pkg/analysis_server/lib/src/analysis_logger.dart

index 5f73552b0145cd7ff92bf7ba2951002b54b5a024..56f14353c0147e95d586ab5d042b52f867acdeef 100644

--- a/pkg/analysis_server/lib/src/analysis_logger.dart

+++ b/pkg/analysis_server/lib/src/analysis_logger.dart

@@ -21,7 +21,7 @@ class AnalysisLogger implements Logger {

AnalysisLogger() {

logging.Logger.root.onRecord.listen((logging.LogRecord record) {

AnalysisEngine.instance.instrumentationService.logLogEntry(

- record.level.name, record.time, record.message);

+ record.level.name, record.time, record.message, record.error, record.stackTrace);

});

}