Load CMA backend from shared library

chromecast/public/media/video_pipeline_device.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROMECAST_MEDIA_CMA_BACKEND_VIDEO_PIPELINE_DEVICE_H_
-#define CHROMECAST_MEDIA_CMA_BACKEND_VIDEO_PIPELINE_DEVICE_H_
+#ifndef CHROMECAST_PUBLIC_MEDIA_VIDEO_PIPELINE_DEVICE_H_
+#define CHROMECAST_PUBLIC_MEDIA_VIDEO_PIPELINE_DEVICE_H_
 
-#include "base/callback.h"
-#include "base/macros.h"
-#include "chromecast/media/cma/backend/media_component_device.h"
-
-namespace gfx {
-class Size;
-}
+#include "media_component_device.h"
 
 namespace chromecast {
+struct Size;
+
 namespace media {
-class DecoderBufferBase;
 struct VideoConfig;
 
 // VideoPipelineDevice -
 //
 // Notes:
 // - Like a regular MediaComponentDevice, frames are possibly rendered only
 //   in the kRunning state.
 //   However, the first frame must be rendered regardless of the clock state:
 //   - no synchronization needed to display the first frame,
 //   - the clock rate has no impact on the presentation of the first frame.
 //
 class VideoPipelineDevice : public MediaComponentDevice {
  public:
-  struct VideoClient {
-    VideoClient();
-    ~VideoClient();
-
-    // Invoked each time the natural size is updated.
-    base::Callback<void(const gfx::Size& natural_size)>
-        natural_size_changed_cb;
+  // Callback interface for natural size of video changing.
+  class VideoClient {
+   public:
+    virtual ~VideoClient() {}
+    virtual void OnNaturalSizeChanged(const Size& size) = 0;
   };
 
-  VideoPipelineDevice();
-  ~VideoPipelineDevice() override;
+  VideoPipelineDevice() {}

[byungchul, 2015/07/27 18:22:23]

not necessary

[halliwell, 2015/07/28 02:19:36]

removed.

+  ~VideoPipelineDevice() override {}
 
   // Registers |client| as the video specific event handler.
-  virtual void SetVideoClient(const VideoClient& client) = 0;
+  // Implementation takes ownership of |client|.

[gunsch, 2015/07/27 17:14:49]

Is there guidance on when |client| should be deleted?

Can we instead control ownership and delete on pipeline teardown to avoid a
small, not-very-noticeable memory leak in case OEM implementation doesn't delete
it?

[halliwell, 2015/07/28 02:19:36]

Indeed, pipeline now owns, simplifies this for OEM.

[byungchul, 2015/07/28 18:05:43]

It would be confusing for vendros if we mix the ownership of objects. TashRunner
takes the ownership of tasks. I am fine with that exception, but please check
others.

[halliwell, 2015/07/28 23:26:06]

Yeah I'm considering going back to vendor ownership here.  The FrameStatus
callback has to be owned by vendors because there's a new one per frame pushed
in.  So it feels more consistent to have them own all callbacks.

When we implement conformance tests, we can pass in a checking implementation
that ensures vendors delete this object on pipeline teardown.

Will wait for gunsch's thoughts on this since it was his suggestion originally.

[gunsch, 2015/07/29 17:04:20]

I like the idea of a conformance test guaranteeing lifetime. I don't think we
have anything that does that today. How hard would it be to add a small test
case for that in this CL (or as a quick follow-up CL?). I'd be much more okay
passing ownership to the shlib in that case.

[halliwell, 2015/07/29 19:58:19]

Don't think it would be too hard, but would prefer follow-up CL purely because
of the time constraints.  I've filed b/22822861 to track internally ...
generalised to cover ownership of all the objects that we pass into CMA backend
now.

So have reverted to backend owning VideoClient.

+  virtual void SetVideoClient(VideoClient* client) = 0;
 
   // Provide the video configuration.
   // Must be called before switching from |kStateUninitialized| to |kStateIdle|.
   // Afterwards, this can be invoked any time the configuration changes.
   // Returns true if the configuration is a supported configuration.
   virtual bool SetConfig(const VideoConfig& config) = 0;
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(VideoPipelineDevice);
 };
 
 }  // namespace media
 }  // namespace chromecast
 
 #endif  // CHROMECAST_MEDIA_CMA_BACKEND_VIDEO_PIPELINE_DEVICE_H_