Load CMA backend from shared library

chromecast/public/media/decoder_buffer.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_PUBLIC_MEDIA_DECODER_BUFFER_H_
+#define CHROMECAST_PUBLIC_MEDIA_DECODER_BUFFER_H_
+
+#include <stdint.h>
+
+#include <cstddef>
+
+#include "chromecast/public/time_delta.h"

[byungchul, 2015/07/27 18:22:23]

should be relative to chromecast/public

[halliwell, 2015/07/28 02:19:35]

TimeDelta removed now anyway.

+#include "stream_id.h"
+
+namespace chromecast {
+namespace media {
+
+class DecryptConfig;
+
+// DecoderBuffer exposes only the properties of an audio/video buffer.
+// The way a DecoderBuffer is created and organized in memory
+// is left as a detail of the implementation of derived classes.
+class DecoderBuffer {

[gunsch, 2015/07/27 17:14:49]

Any chance we can change the name, to avoid confusion with media::DecoderBuffer?

[halliwell, 2015/07/28 02:19:35]

Happy to change the name.  DecryptConfig is a similar case.  What do you think
of CastDecoderBuffer and CastDecryptConfig?  I think there's a benefit to using
a prefix rather than a completely different name, because while we want to avoid
confusion, it's also useful to see at a glance that they're the same thing (one
just a wrapper around the other).

[halliwell, 2015/07/28 23:26:06]

Ok, renamed to CastDecoderBuffer, CastDecryptConfig (and implementations are
CastDecoderBufferImpl, CastDecryptConfigImpl).

+ public:
+  DecoderBuffer() {}

[byungchul, 2015/07/27 18:22:23]

not necessary

[halliwell, 2015/07/28 02:19:35]

removed.

+  virtual ~DecoderBuffer() {}
+
+  // Returns the stream id of this decoder buffer belonging to. it's optional
+  // and default value is kPrimary.
+  virtual StreamId stream_id() const = 0;

[byungchul, 2015/07/27 18:22:23]

Isn't const in public apis too restricted?

[halliwell, 2015/07/28 02:19:35]

This isn't an API for vendors to implement.  It's just to wrap DecoderBufferBase
without leaking Chromium types into public API.  So there will only be 1
implementation and this is its signature.

+
+  // Returns the PTS of the frame.
+  virtual TimeDelta timestamp() const = 0;
+
+  // Sets the PTS of the frame.
+  virtual void set_timestamp(TimeDelta timestamp) = 0;

[byungchul, 2015/07/27 18:22:23]

No simple setters/getters in public apis. Otherwise, a simple struct?

[halliwell, 2015/07/28 02:19:35]

I removed this and also writable_data.  I had been just duplicating the
DecoderBufferBase API but of course vendors don't need access to these parts.

[byungchul, 2015/07/28 18:05:43]

If it is not for vendors, why is this defined in public?

[halliwell, 2015/07/28 23:26:06]

We need to pass buffers to vendors, this is their API for accessing buffer data.
 They just don't need the setters, so I removed them in the later patchset.

+
+  // Gets the frame data.
+  virtual const uint8_t* data() const = 0;
+  virtual uint8_t* writable_data() const = 0;
+
+  // Returns the size of the frame in bytes.
+  virtual size_t data_size() const = 0;
+
+  // Returns the decrypt configuration.
+  // Returns NULL if the buffer has no decrypt info.
+  virtual const DecryptConfig* decrypt_config() const = 0;
+
+  // Indicate if this is a special frame that indicates the end of the stream.
+  // If true, functions to access the frame content cannot be called.
+  virtual bool end_of_stream() const = 0;
+};
+
+}  // namespace media
+}  // namespace chromecast
+
+#endif  // CHROMECAST_MEDIA_CMA_BASE_DECODER_BUFFER_BASE_H_