On 2015/07/27 17:14:49, gunsch wrote:
> did you figure it out? :)
I did now. I discovered that:
* Up a level, headers were able to #include "chromecast_export.h" by virtue of
it being in the same directory (the rule is the including file's directory gets
searched first before the include paths)
* You can't use that fact here to #include "../chromecast_export.h" because DEPS
doesn't allow it (and the DEPS checker crashes if you put ".." in it!)
So after discussion with Byungchul, it seems like we should have
chromecast/public added to include paths for our targets. I did this by adding
to target_defaults in chromecast.gyp and media.gyp ... not sure if we should
have something more targeted, but it seems like errors could pop up at any time
if we don't add it to all targets?
5 "+chromecast/public",
6 "-base",
7 "-content",
8 "-net",
9 "-ui",
10 ]
byungchul
2015/07/27 18:22:23
chromecast/public dir will be distributed to oem p
chromecast/public dir will be distributed to oem partners. Please add a comment
that this file must be excluded from that.
On 2015/07/27 18:22:23, byungchul wrote:
> chromecast/public dir will be distributed to oem partners. Please add a
comment
> that this file must be excluded from that.
Issue 1257013003: Load CMA backend from shared library
(Closed)
Created 5 years, 4 months ago by halliwell
Modified 5 years, 4 months ago
Reviewers: gunsch, byungchul, servolk, alokp
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 175