chromecast/public/media/DEPS - Issue 1257013003: Load CMA backend from shared library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/public/media/DEPS

Issue 1257013003: Load CMA backend from shared library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test + android fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromecast/media/cma/pipeline/media_pipeline_impl.cc ('K') | « chromecast/public/cast_media_shlib.h ('k') | chromecast/public/media/audio_pipeline_device.h » ('j') | chromecast/public/media/audio_pipeline_device.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 include_rules = [

	2 # chromecast/public/media should not depend on anything Chromium specific

	3 "-chromecast",
	gunsch 2015/07/27 17:14:49 These rules should all be guaranteed by chromecast These rules should all be guaranteed by chromecast/public/DEPS already. No need to duplicate. halliwell 2015/07/28 02:19:35 got it. removing the file anyway though. Show quoted text On 2015/07/27 17:14:49, gunsch wrote: > These rules should all be guaranteed by chromecast/public/DEPS already. No need > to duplicate. got it. removing the file anyway though.
	4 # TODO(halliwell) ... figure out whether to use relative include path
	gunsch 2015/07/27 17:14:49 did you figure it out? :) did you figure it out? :) halliwell 2015/07/28 02:19:35 I did now. I discovered that: * Up a level, heade Show quoted text On 2015/07/27 17:14:49, gunsch wrote: > did you figure it out? :) I did now. I discovered that: * Up a level, headers were able to #include "chromecast_export.h" by virtue of it being in the same directory (the rule is the including file's directory gets searched first before the include paths) * You can't use that fact here to #include "../chromecast_export.h" because DEPS doesn't allow it (and the DEPS checker crashes if you put ".." in it!) So after discussion with Byungchul, it seems like we should have chromecast/public added to include paths for our targets. I did this by adding to target_defaults in chromecast.gyp and media.gyp ... not sure if we should have something more targeted, but it seems like errors could pop up at any time if we don't add it to all targets?
	5 "+chromecast/public",

	6 "-base",

	7 "-content",

	8 "-net",

	9 "-ui",

	10 ]
	byungchul 2015/07/27 18:22:23 chromecast/public dir will be distributed to oem p chromecast/public dir will be distributed to oem partners. Please add a comment that this file must be excluded from that. halliwell 2015/07/28 02:19:35 File deleted anyway. Show quoted text On 2015/07/27 18:22:23, byungchul wrote: > chromecast/public dir will be distributed to oem partners. Please add a comment > that this file must be excluded from that. File deleted anyway.
OLD	NEW