Load CMA backend from shared library

chromecast/media/base/media_codec_support.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/base/media_codec_support.h"
 
-// TODO(gunsch/servolk): delete this file once a solution exists upstream.
+#include "base/bind.h"
+#include "chromecast/media/base/media_caps.h"
+#include "chromecast/public/media_codec_support_shlib.h"
+#include "net/base/mime_util.h"
 
+// TODO(gunsch/servolk): delete this definition once a solution exists upstream.

[gunsch, 2015/07/27 17:14:49]

You might be able to resolve this TODO now. Internal implementation shouldn't be
calling net::DefaultIsCodecSupported after your changes.

[servolk, 2015/07/27 21:25:47]

It's true, internal implementations won't call this anymore. But the problem is
that DefaultIsCodecSupported still doesn't exist in the upstream. So we'll still
need to provide our own implementation for upstream cast_shell builds.

[halliwell, 2015/07/28 02:19:35]

I could remove this TODO by just returning true lower down in this file.  And
we'd replace with a downstream [Local] change to call DefaultIsCodecSupported. 
Alternatively, we remove this stub implementation downstream.

Either way, the TODO in the header will still be there (to define
net::IsCodecSupportedCB).

Let me know if you'd prefer any changes to what's here.

[gunsch, 2015/07/29 17:04:19]

Yeah, go ahead and delete it. We shouldn't be defining things in the net
namespace :)

The only reason we checked it in was because internal code expected it in the
chromium/src repo (due to our downstream hack), so to keep building we at least
needed a definition here. Since you're moving that out of internal, I'd rather
just "return true" below with a TODO.

[halliwell, 2015/07/29 19:58:19]

Ok, removed.

 namespace net {
-
 bool DefaultIsCodecSupported(const std::string&) {
   return true;
 }
+}
 
-}  // namespace net
+namespace chromecast {
+namespace media {
+namespace {
 
+bool IsCodecSupported(const std::string& codec) {
+  MediaCodecSupportShlib::CodecSupport platform_support =
+      MediaCodecSupportShlib::IsSupported(codec);
+  if (platform_support == MediaCodecSupportShlib::kSupported)
+    return true;
+  else if (platform_support == MediaCodecSupportShlib::kNotSupported)
+    return false;
+
+  if (codec == "aac51") {
+    return ::media::HdmiSinkSupportsPcmSurroundSound();
+  }
+  if (codec == "ac-3" || codec == "mp4a.a5") {
+    return ::media::HdmiSinkSupportsAC3();
+  }
+  if (codec == "ec-3" || codec == "mp4a.a6") {
+    return ::media::HdmiSinkSupportsEAC3();
+  }
+
+  return net::DefaultIsCodecSupported(codec);
+}
+
+}  // namespace
+
+net::IsCodecSupportedCB GetIsCodecSupportedOnChromecastCB() {
+  return base::Bind(&IsCodecSupported);
+}
+
+}  // namespace media
+}  // namespace chromecast