Load CMA backend from shared library

chromecast/base/task_runner_impl.cc

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromecast/base/task_runner_impl.h"
+
+#include "base/bind.h"
+#include "base/location.h"
+#include "base/single_thread_task_runner.h"
+#include "base/thread_task_runner_handle.h"
+#include "chromecast/base/time_conversions.h"
+
+namespace chromecast {
+
+TaskRunnerImpl::TaskRunnerImpl()
+    : runner_(base::ThreadTaskRunnerHandle::Get()) {}

[byungchul, 2015/07/27 18:22:22]

DCHECK(runner_.get());

[halliwell, 2015/07/28 02:19:34]

Done.

+
+TaskRunnerImpl::~TaskRunnerImpl() {}

[byungchul, 2015/07/27 18:22:22]

wrap line after {

[halliwell, 2015/07/28 02:19:35]

clang format prefers it this way

+
+bool TaskRunnerImpl::BelongsToCurrentThread() {
+  return runner_->BelongsToCurrentThread();
+}
+
+bool TaskRunnerImpl::PostTask(Task* task) {
+  return runner_->PostTask(FROM_HERE,

[servolk, 2015/07/27 21:25:47]

Nit: this will make it look like all posttasks are posted from here. Can we pass
FROM_HERE as a parameter from the call site to preserve the actual PostTask
origin?

[halliwell, 2015/07/28 02:19:35]

Good point.  the downside to passing the info through is we need to introduce
another chromecast/public type to hold that info.  I'm not sure how much it's
worth it, wdyt?  It's not super hard if this information is going to be very
useful.

[servolk, 2015/07/28 18:12:55]

TBH I don't remember if I ever used this info directly, so it's not strictly
necessary. But it would be still nice to fix this, probably some analysis
tool(s) depend on this. Maybe create a tracking P1 bug/TODO for this and leave
as is for now?

[halliwell, 2015/07/28 23:26:05]

Ok, TODO and internal tracking bug filed.

[servolk, 2015/07/29 01:46:26]

Wait, I meant a TODO comment in code, e.g. //TODO(haliwell): Fix FROM_HERE
But I don't see anything like that in task_runner_impl.* or task_runner.h.
Also if you are keeping the version which allows specifying delay, let's keep
the name PostDelayedTask for consistency.

[halliwell, 2015/07/29 01:55:54]

The TODO is in task_runner_impl.cc.  Not sure PostDelayedTask is accurate, given
it's frequently used to post tasks without delay now (delay = 0) after merging
them.  We should view the API from vendor's perspective, they don't care about
the existence of PostDelayedTask in chromium.

+                           base::Bind(&Task::Run, base::Owned(task)));
+}
+
+bool TaskRunnerImpl::PostDelayedTask(Task* task, TimeDelta delay) {
+  return runner_->PostDelayedTask(FROM_HERE,

[servolk, 2015/07/27 21:25:47]

Same

[halliwell, 2015/07/28 02:19:35]

Same, need to introduce a new type.  Let me know what you think.

+                                  base::Bind(&Task::Run, base::Owned(task)),
+                                  ToBaseTimeDelta(delay));
+}
+
+}  // namespace chromecast