Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1257003002: OnPreeditChanged should update the internal composition after checking it. (Closed)

Created:
5 years, 5 months ago by Shu Chen
Modified:
5 years, 5 months ago
Reviewers:
James Su
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OnPreeditChanged should update the internal composition after checking it. BUG=513124 TEST=Issue 513124 doesn't repro locally and the updated test CompositionUpdateWithCommitTest can pass. Committed: https://crrev.com/290f8e4e2f93e8095a3a22fc8f65e02b385f4526 Cr-Commit-Position: refs/heads/master@{#340427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ui/base/ime/input_method_auralinux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_auralinux_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Shu Chen
Please review. Thanks
5 years, 5 months ago (2015-07-27 03:17:03 UTC) #2
James Su
lgtm
5 years, 5 months ago (2015-07-27 03:51:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257003002/1
5 years, 5 months ago (2015-07-27 03:51:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-27 07:04:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-27 07:05:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/290f8e4e2f93e8095a3a22fc8f65e02b385f4526
Cr-Commit-Position: refs/heads/master@{#340427}

Powered by Google App Engine
This is Rietveld 408576698