Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 125693002: Implement lstat by stat in nacl_io (Closed)

Created:
6 years, 11 months ago by hamaji
Modified:
6 years, 11 months ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews, binji, Sam Clegg
Visibility:
Public.

Description

Implement lstat by stat in nacl_io As nacl_io does not support TEST=./build_tools/build_sdk.py TEST=./build_tools/test_sdk.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243771

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hamaji
6 years, 11 months ago (2014-01-07 04:02:15 UTC) #1
Sam Clegg
Can you add a test(s) and run the try bots (git cl try)
6 years, 11 months ago (2014-01-07 17:28:32 UTC) #2
hamaji
Done.
6 years, 11 months ago (2014-01-08 15:21:32 UTC) #3
binji
lgtm
6 years, 11 months ago (2014-01-08 17:16:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/125693002/60001
6 years, 11 months ago (2014-01-09 00:42:14 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 04:40:02 UTC) #6
Message was sent while issue was closed.
Change committed as 243771

Powered by Google App Engine
This is Rietveld 408576698