base/threading/platform_thread_posix.cc - Issue 1256903005: base/threading: fix a potential race issue on start_event_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/platform_thread_posix.cc

Issue 1256903005: base/threading: fix a potential race issue on start_event_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [rebase] Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/platform_thread_posix.cc

diff --git a/base/threading/platform_thread_posix.cc b/base/threading/platform_thread_posix.cc

index 61d75861d3f2e89f7a2b58b76a4a9a8a755b5f5a..0adb92dbce50da89aa424154e3af9f3ce5b36a8d 100644

--- a/base/threading/platform_thread_posix.cc

+++ b/base/threading/platform_thread_posix.cc

@@ -100,8 +100,7 @@ bool CreateThread(size_t stack_size,

params->priority = priority;

pthread_t handle;

- int err =

- pthread_create(&handle, &attributes, ThreadFunc, params.get());

+ int err = pthread_create(&handle, &attributes, ThreadFunc, params.get());

bool success = !err;

if (success) {

// ThreadParams should be deleted on the created thread after used.

« no previous file with comments | « no previous file | base/threading/thread.h » ('j') | no next file with comments »