make fontscalar gammatext lcdtext typeface verttext2 gm portable

make fontscalar gammatext lcdtext typeface verttext2 gm portable

Pass generic font names to tool util function to generate
platform specific fonts and gm test output by unique name.

R=bungeman@google.com

Committed: https://skia.googlesource.com/skia/+/37213558e6d269807cde031e59b9567d0db6e471

[caryclark, 2015-07-24 17:02:23]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-24 17:02:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256903002/1

[commit-bot: I haz the power, 2015-07-24 17:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-24 17:10:03]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-07-24 17:54:53]

https://codereview.chromium.org/1256903002/diff/1/gm/typeface.cpp
File gm/typeface.cpp (right):

https://codereview.chromium.org/1256903002/diff/1/gm/typeface.cpp#newcode20
gm/typeface.cpp:20: class TypefaceGM : public skiagm::GM {
I think the use case for this GM is completely covered by other GMs, and better.
For example, the fontmgr_iter gm is essentially doing this, but with a list of
typefaces actually known to be on the system. I would be all for just removing
this particular gm. I don't think it's ever detected anything interesting.

Note that the other gm in this file, TypefaceStylesGM below, still does
something at least somewhat interesting.

https://codereview.chromium.org/1256903002/diff/1/tools/sk_tool_utils.cpp
File tools/sk_tool_utils.cpp (right):

https://codereview.chromium.org/1256903002/diff/1/tools/sk_tool_utils.cpp#new...
tools/sk_tool_utils.cpp:48: if (platform .equals("iOS")) {
nit: Probably don't want the space between 'platform' and '.equals'.

[caryclark, 2015-07-24 17:59:50]

https://codereview.chromium.org/1256903002/diff/1/gm/typeface.cpp
File gm/typeface.cpp (right):

https://codereview.chromium.org/1256903002/diff/1/gm/typeface.cpp#newcode20
gm/typeface.cpp:20: class TypefaceGM : public skiagm::GM {
On 2015/07/24 17:54:53, bungeman1 wrote:
> I think the use case for this GM is completely covered by other GMs, and
better.
> For example, the fontmgr_iter gm is essentially doing this, but with a list of
> typefaces actually known to be on the system. I would be all for just removing
> this particular gm. I don't think it's ever detected anything interesting.
> 
> Note that the other gm in this file, TypefaceStylesGM below, still does
> something at least somewhat interesting.

Done.

https://codereview.chromium.org/1256903002/diff/1/tools/sk_tool_utils.cpp
File tools/sk_tool_utils.cpp (right):

https://codereview.chromium.org/1256903002/diff/1/tools/sk_tool_utils.cpp#new...
tools/sk_tool_utils.cpp:48: if (platform .equals("iOS")) {
On 2015/07/24 17:54:53, bungeman1 wrote:
> nit: Probably don't want the space between 'platform' and '.equals'.

Done.

[caryclark, 2015-07-24 18:00:00]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-07-24 18:00:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256903002/40001

[commit-bot: I haz the power, 2015-07-24 18:00:06]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-07-25 00:00 UTC

[bungeman-skia, 2015-07-24 18:05:53]

lgtm

[commit-bot: I haz the power, 2015-07-24 18:08:04]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/37213558e6d269807cde031e59b9567d0db6e471