content/browser/loader/resource_dispatcher_host_impl.cc - Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: "Address Matt's code review comments" Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tab_contents/render_view_context_menu_browsertest.cc ('K') | « content/browser/download/download_manager_impl.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index de3c2d85ae44909773f54b30687d39c02f461b1f..b4c041fa132f490391dc9257bca974d3d4837c21 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -458,7 +458,7 @@ net::Error ResourceDispatcherHostImpl::BeginDownload(

base::debug::Alias(url_buf);

CHECK(ContainsKey(active_resource_contexts_, context));

- request->set_referrer(MaybeStripReferrer(GURL(request->referrer())).spec());

+ request->SetReferrer(MaybeStripReferrer(GURL(request->referrer())).spec());

int extra_load_flags = net::LOAD_IS_DOWNLOAD;

if (prefer_cache) {

// If there is upload data attached, only retrieve from cache because there

@@ -910,7 +910,7 @@ void ResourceDispatcherHostImpl::BeginRequest(

request->set_method(request_data.method);

request->set_first_party_for_cookies(request_data.first_party_for_cookies);

- request->set_referrer(referrer.url.spec());

+ request->SetReferrer(referrer.url.spec());

webkit_glue::ConfigureURLRequestForReferrerPolicy(request,

referrer.policy);

net::HttpRequestHeaders headers;

@@ -1211,7 +1211,7 @@ void ResourceDispatcherHostImpl::BeginSaveFile(

scoped_ptr<net::URLRequest> request(

request_context->CreateRequest(url, NULL));

request->set_method("GET");

- request->set_referrer(MaybeStripReferrer(referrer.url).spec());

+ request->SetReferrer(MaybeStripReferrer(referrer.url).spec());

webkit_glue::ConfigureURLRequestForReferrerPolicy(request.get(),

referrer.policy);

// So far, for saving page, we need fetch content from cache, in the