content/browser/loader/resource_dispatcher_host_unittest.cc - Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address code review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/loader/resource_dispatcher_host_unittest.cc

diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc

index 139b416a57fc5685619327c07990036c4446b232..394ecb9455b97c2e27bbd4143763092198dc0084 100644

--- a/content/browser/loader/resource_dispatcher_host_unittest.cc

+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc

@@ -1287,7 +1287,7 @@ TEST_F(ResourceDispatcherHostTest, CalculateApproximateMemoryCost) {

ResourceDispatcherHostImpl::CalculateApproximateMemoryCost(&req));

// Add 9 bytes of referrer.

- req.set_referrer("123456789");

+ req.SetReferrer("123456789");

mef 2013/03/18 16:42:07 I've verified that this test passes.

EXPECT_EQ(4436,

ResourceDispatcherHostImpl::CalculateApproximateMemoryCost(&req));

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/resource_loader.cc » ('j') | no next file with comments »