chrome/browser/automation/url_request_automation_job.cc - Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/url_request_automation_job.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address code review comments, add UMA_HISTOGRAM Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/automation/url_request_automation_job.cc

diff --git a/chrome/browser/automation/url_request_automation_job.cc b/chrome/browser/automation/url_request_automation_job.cc

index d68cf68039a93362b66c8798b4ccd4760d7841aa..3c67271e9b3ddfc1981aa512ef8fd0b0ee05ebc3 100644

--- a/chrome/browser/automation/url_request_automation_job.cc

+++ b/chrome/browser/automation/url_request_automation_job.cc

@@ -482,8 +482,9 @@ void URLRequestAutomationJob::StartAsync() {

}

- // Ensure that we do not send username and password fields in the referrer.

- GURL referrer(request_->GetSanitizedReferrer());

+ // URLRequest::SetReferrer() ensures that

pauljensen 2013/03/15 21:50:00 Can you move more words onto this line to bring it

mef 2013/03/18 16:42:07 Done.

+ // we do not send username and password fields in the referrer.

+ GURL referrer(request_->referrer());

// The referrer header must be suppressed if the preceding URL was

// a secure one and the new one is not.

« no previous file with comments | « no previous file | chrome/browser/net/chrome_network_delegate.cc » ('j') | chrome/browser/tab_contents/render_view_context_menu.cc » ('J')