Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: net/url_request/url_request.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address code review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 5d3e26b47fedbce7b639f88bab9879b91e1a9667..ea55d98749dbfffe3b2caa8c4561deec4024e250 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -426,23 +426,21 @@ void URLRequest::set_method(const std::string& method) {
method_ = method;
}
-void URLRequest::set_referrer(const std::string& referrer) {
+void URLRequest::SetReferrer(const std::string& referrer) {
DCHECK(!is_pending_);
referrer_ = referrer;
-}
-
-GURL URLRequest::GetSanitizedReferrer() const {
- GURL ret(referrer());
-
- // Ensure that we do not send username and password fields in the referrer.
- if (ret.has_username() || ret.has_password()) {
+ // Ensure that we do not send url fragment,
pauljensen 2013/03/15 13:37:45 Please capitalize URL. Can we put "username and p
mef 2013/03/15 16:36:42 Done.
+ // username and password fields in the referrer.
+ GURL referrer_url(referrer);
+ if (referrer_url.is_valid() && (referrer_url.has_ref() ||
+ referrer_url.has_username() || referrer_url.has_password())) {
GURL::Replacements referrer_mods;
+ referrer_mods.ClearRef();
referrer_mods.ClearUsername();
referrer_mods.ClearPassword();
- ret = ret.ReplaceComponents(referrer_mods);
+ referrer_url = referrer_url.ReplaceComponents(referrer_mods);
+ referrer_ = referrer_url.spec();
}
-
- return ret;
}
void URLRequest::set_referrer_policy(ReferrerPolicy referrer_policy) {

Powered by Google App Engine
This is Rietveld 408576698