content/browser/loader/resource_loader.cc - Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_loader.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address code review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tab_contents/render_view_context_menu_browsertest.cc ('K') | « content/browser/loader/resource_dispatcher_host_unittest.cc ('k') | content/browser/renderer_host/render_message_filter.cc » ('j') | net/url_request/url_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_loader.cc

diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc

index e4716dd71ef3d3f0df767345db882f3ff4863b3c..0e54e626768b24e40c9fa561c0d01ed5f26f8723 100644

--- a/content/browser/loader/resource_loader.cc

+++ b/content/browser/loader/resource_loader.cc

@@ -526,10 +526,11 @@ void ResourceLoader::CompleteResponseStarted() {

if (command_line.HasSwitch(switches::kSitePerProcess) &&

GetRequestInfo()->GetResourceType() == ResourceType::SUB_FRAME &&

response->head.mime_type == "text/html" &&

- !request_->url().SchemeIs(chrome::kChromeUIScheme) &&

- !SiteInstance::IsSameWebSite(NULL, request_->url(),

- request_->GetSanitizedReferrer())) {

- response->head.mime_type = "application/browser-plugin";

+ !request_->url().SchemeIs(chrome::kChromeUIScheme)) {

+ GURL referrer(request_->referrer());

pauljensen 2013/03/15 13:37:45 Can we just go back to the old code but use GURL(r

mef 2013/03/15 16:36:42 Done.

+ if (!SiteInstance::IsSameWebSite(NULL, request_->url(), referrer)) {

+ response->head.mime_type = "application/browser-plugin";

+ }

}

if (request_->ssl_info().cert) {