Chromium Code Reviews| Index: chrome/browser/tab_contents/render_view_context_menu.cc |
| diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc |
| index 8cb23b524a7e5fe895810a480f0c385e9981ae33..b086d30572d5a81fb20845ddb2c3d2a50b5416ef 100644 |
| --- a/chrome/browser/tab_contents/render_view_context_menu.cc |
| +++ b/chrome/browser/tab_contents/render_view_context_menu.cc |
| @@ -1849,9 +1849,21 @@ void RenderViewContextMenu::OpenURL( |
| const GURL& url, const GURL& referrer, int64 frame_id, |
| WindowOpenDisposition disposition, |
| content::PageTransition transition) { |
| + // Ensure that we do not send url fragment, |
|
pauljensen
2013/03/14 18:53:44
Capitalize URL. Let's avoid "we" by saying "Ensur
mef
2013/03/14 20:31:38
Done.
|
| + // username and password fields in the referrer. |
| + GURL referrer_url(referrer); |
|
pauljensen
2013/03/14 18:53:44
"referrer_url" doesn't indicate its difference fro
mef
2013/03/14 20:31:38
Done.
|
| + if (referrer_url.is_valid() && (referrer_url.has_ref() || |
| + referrer_url.has_username() || referrer_url.has_password())) { |
| + GURL::Replacements referrer_mods; |
| + referrer_mods.ClearRef(); |
| + referrer_mods.ClearUsername(); |
| + referrer_mods.ClearPassword(); |
| + referrer_url = referrer_url.ReplaceComponents(referrer_mods); |
| + } |
| + |
| WebContents* new_contents = source_web_contents_->OpenURL(OpenURLParams( |
| - url, content::Referrer(referrer, params_.referrer_policy), disposition, |
| - transition, false)); |
| + url, content::Referrer(referrer_url, params_.referrer_policy), |
| + disposition, transition, false)); |
| if (!new_contents) |
| return; |