Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option.

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/debug/stack_trace.h"
 #include "base/lazy_instance.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop.h"
+#include "base/metrics/histogram.h"
 #include "base/metrics/stats_counters.h"
 #include "base/stl_util.h"
 #include "base/synchronization/lock.h"
 #include "net/base/auth.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/load_flags.h"
 #include "net/base/load_timing_info.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log.h"
 #include "net/base/network_change_notifier.h"
@@ skipping 394 matching lines @@
 void URLRequest::set_first_party_for_cookies(
     const GURL& first_party_for_cookies) {
   first_party_for_cookies_ = first_party_for_cookies;
 }
 
 void URLRequest::set_method(const std::string& method) {
   DCHECK(!is_pending_);
   method_ = method;
 }
 
-void URLRequest::set_referrer(const std::string& referrer) {
+void URLRequest::SetReferrer(const std::string& referrer) {
   DCHECK(!is_pending_);
   referrer_ = referrer;
-}
-
-GURL URLRequest::GetSanitizedReferrer() const {
-  GURL ret(referrer());
-
-  // Ensure that we do not send username and password fields in the referrer.
-  if (ret.has_username() || ret.has_password()) {
+  // Ensure that we do not send URL fragment, username and password
+  // fields in the referrer.
+  GURL referrer_url(referrer);
+  UMA_HISTOGRAM_BOOLEAN("Net.URLRequest_SetReferrer_IsValid",
+                        referrer_url.is_valid());

[mmenke, 2013/03/19 19:01:09]

An empty referrer URL is presumably not a valid GURL, but must be used, per
spec, when going from https to http, or when navigating to a URL from the
omnibox, to a bookmark, or from an external program, so they should either be
excluded from the histogram, or treated as valid.

[mmenke, 2013/03/19 19:01:09]

What's the motivation for gathering this information?  I'm not strongly opposed
to it, just unsure of the motivation.

[mef, 2013/03/19 21:40:29]

Done.

[mef, 2013/03/19 21:40:29]

The idea is to see how often are invalid urls seen as referrers, so potentially
change referrer_ type from std::string to GURL.

[mmenke, 2013/03/20 16:33:51]

Sounds reasonable to me.

+  if (referrer_url.is_valid() && (referrer_url.has_ref() ||
+      referrer_url.has_username() ||  referrer_url.has_password())) {
     GURL::Replacements referrer_mods;
+    referrer_mods.ClearRef();
     referrer_mods.ClearUsername();
     referrer_mods.ClearPassword();
-    ret = ret.ReplaceComponents(referrer_mods);
+    referrer_url = referrer_url.ReplaceComponents(referrer_mods);
+    referrer_ = referrer_url.spec();
   }
-
-  return ret;
 }
 
 void URLRequest::set_referrer_policy(ReferrerPolicy referrer_policy) {
   DCHECK(!is_pending_);
   referrer_policy_ = referrer_policy;
 }
 
 void URLRequest::set_delegate(Delegate* delegate) {
   delegate_ = delegate;
 }
@@ skipping 542 matching lines @@
       new base::debug::StackTrace(NULL, 0);
   *stack_trace_copy = stack_trace;
   stack_trace_.reset(stack_trace_copy);
 }
 
 const base::debug::StackTrace* URLRequest::stack_trace() const {
   return stack_trace_.get();
 }
 
 }  // namespace net