Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256853004: Fixing src rect constraint support for drawImage with SkPicture (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixing src rect constraint support for drawImage with SkPicture Follow-up to https://codereview.chromium.org/1228083004 BUG=skia: Committed: https://skia.googlesource.com/skia/+/6e9aed9dfe532d31c200b6258fcfb28fd90738f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256853004/1
5 years, 4 months ago (2015-07-27 18:31:44 UTC) #2
Justin Novosad
PTAL. There appears to already be test coverage for this in gm. Not sure why ...
5 years, 4 months ago (2015-07-27 18:34:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 18:39:11 UTC) #6
reed1
lgtm
5 years, 4 months ago (2015-07-27 20:10:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256853004/1
5 years, 4 months ago (2015-07-27 20:11:20 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 20:11:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6e9aed9dfe532d31c200b6258fcfb28fd90738f7

Powered by Google App Engine
This is Rietveld 408576698