Issue 1256843004: Merge --origin and --origin-path in devtools scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256843004: Merge --origin and --origin-path in devtools scripts. (Closed)

Created:
5 years, 4 months ago by ppi

Modified:
5 years, 4 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Merge --origin and --origin-path in devtools scripts. It's error prone to expose both --origin and --origin-path. This patch merges both into just --origin, which will setup the server and port forwarding if a local destination is passed. This matches what the run scripts do for --map-origin and --map-url destinations. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cc1b5a8fdf695e0574f443c204ffe3d9f73585b0

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -15 lines)			Patch
M	mojo/devtools/common/devtoolslib/shell_arguments.py	View	4 chunks	+12 lines, -8 lines	0 comments	Download
M	mojo/devtools/common/mojo_run	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	mojo/tools/apptest_runner.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 4 months ago (2015-07-28 13:32:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc1b5a8fdf695e0574f443c204ffe3d9f73585b0 (presubmit successful).

Expand Messages | Collapse Messages