Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: content/browser/service_worker/service_worker_utils.cc

Issue 1256833004: Move Service Worker %2f validation logic from browser into Blink (3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch back to previous validation routine for %2f in scopes. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_utils.cc
diff --git a/content/browser/service_worker/service_worker_utils.cc b/content/browser/service_worker/service_worker_utils.cc
index 71ddc611d00d9fd00382bcc119fb819dafca3ba3..8a63857f63c44ad7a3ff10caa7256f359f9fcafb 100644
--- a/content/browser/service_worker/service_worker_utils.cc
+++ b/content/browser/service_worker/service_worker_utils.cc
@@ -94,11 +94,13 @@ bool ServiceWorkerUtils::ContainsDisallowedCharacter(
std::string* error_message) {
if (PathContainsDisallowedCharacter(scope) ||
PathContainsDisallowedCharacter(script_url)) {
- *error_message = "The provided scope ('";
- error_message->append(scope.spec());
- error_message->append("') or scriptURL ('");
- error_message->append(script_url.spec());
- error_message->append("') includes a disallowed escape character.");
+ if (error_message) {
+ *error_message = "The provided scope ('";
+ error_message->append(scope.spec());
+ error_message->append("') or scriptURL ('");
+ error_message->append(script_url.spec());
+ error_message->append("') includes a disallowed escape character.");
+ }
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698