Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 1256833004: Move Service Worker %2f validation logic from browser into Blink (3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up test for style. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
index 462d093bae277e4b025794237f480e329178cbfa..5e4aa27430c2dc3805ec5877ce0f8cee7e0112cc 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
@@ -310,6 +310,38 @@ TEST_F(ServiceWorkerDispatcherHostTest, Register_CrossOriginShouldFail) {
EXPECT_EQ(6, dispatcher_host_->bad_messages_received_count_);
}
+TEST_F(ServiceWorkerDispatcherHostTest, Register_BadCharactersShouldFail) {
+ const int64 kProviderId = 99; // Dummy value
+ scoped_ptr<ServiceWorkerProviderHost> host(
+ CreateServiceWorkerProviderHost(kProviderId));
+ host->SetDocumentUrl(GURL("https://www.example.com/"));
+ context()->AddProviderHost(host.Pass());
+
+ SendRegister(kProviderId, GURL("https://www.example.com/%2f"),
+ GURL("https://www.example.com/"));
+ EXPECT_EQ(1, dispatcher_host_->bad_messages_received_count_);
+
+ SendRegister(kProviderId, GURL("https://www.example.com/%2F"),
+ GURL("https://www.example.com/"));
+ EXPECT_EQ(2, dispatcher_host_->bad_messages_received_count_);
+
+ SendRegister(kProviderId, GURL("https://www.example.com/"),
+ GURL("https://www.example.com/%2f"));
+ EXPECT_EQ(3, dispatcher_host_->bad_messages_received_count_);
+
+ SendRegister(kProviderId, GURL("https://www.example.com/%5c"),
+ GURL("https://www.example.com/"));
+ EXPECT_EQ(4, dispatcher_host_->bad_messages_received_count_);
+
+ SendRegister(kProviderId, GURL("https://www.example.com/"),
+ GURL("https://www.example.com/%5c"));
+ EXPECT_EQ(5, dispatcher_host_->bad_messages_received_count_);
+
+ SendRegister(kProviderId, GURL("https://www.example.com/"),
+ GURL("https://www.example.com/%5C"));
+ EXPECT_EQ(6, dispatcher_host_->bad_messages_received_count_);
+}
+
TEST_F(ServiceWorkerDispatcherHostTest,
Register_FileSystemDocumentShouldFail) {
const int64 kProviderId = 99; // Dummy value
« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698