Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Side by Side Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 1256833004: Move Service Worker %2f validation logic from browser into Blink (3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up test for style. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_dispatcher_host_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_dispatcher_host.h" 5 #include "content/browser/service_worker/service_worker_dispatcher_host.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/profiler/scoped_tracker.h" 8 #include "base/profiler/scoped_tracker.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/trace_event/trace_event.h" 10 #include "base/trace_event/trace_event.h"
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 328
329 if (!CanRegisterServiceWorker( 329 if (!CanRegisterServiceWorker(
330 provider_host->document_url(), pattern, script_url)) { 330 provider_host->document_url(), pattern, script_url)) {
331 bad_message::ReceivedBadMessage(this, bad_message::SWDH_REGISTER_CANNOT); 331 bad_message::ReceivedBadMessage(this, bad_message::SWDH_REGISTER_CANNOT);
332 return; 332 return;
333 } 333 }
334 334
335 std::string error_message; 335 std::string error_message;
336 if (ServiceWorkerUtils::ContainsDisallowedCharacter(pattern, script_url, 336 if (ServiceWorkerUtils::ContainsDisallowedCharacter(pattern, script_url,
337 &error_message)) { 337 &error_message)) {
338 Send(new ServiceWorkerMsg_ServiceWorkerRegistrationError( 338 bad_message::ReceivedBadMessage(this, bad_message::SWDH_REGISTER_CANNOT);
339 thread_id, request_id, WebServiceWorkerError::ErrorTypeSecurity,
340 base::ASCIIToUTF16(kServiceWorkerRegisterErrorPrefix) +
341 base::UTF8ToUTF16(error_message)));
342 return; 339 return;
343 } 340 }
344 341
345 if (!GetContentClient()->browser()->AllowServiceWorker( 342 if (!GetContentClient()->browser()->AllowServiceWorker(
346 pattern, provider_host->topmost_frame_url(), resource_context_, 343 pattern, provider_host->topmost_frame_url(), resource_context_,
347 render_process_id_, provider_host->frame_id())) { 344 render_process_id_, provider_host->frame_id())) {
348 Send(new ServiceWorkerMsg_ServiceWorkerRegistrationError( 345 Send(new ServiceWorkerMsg_ServiceWorkerRegistrationError(
349 thread_id, request_id, WebServiceWorkerError::ErrorTypeUnknown, 346 thread_id, request_id, WebServiceWorkerError::ErrorTypeUnknown,
350 base::ASCIIToUTF16(kServiceWorkerRegisterErrorPrefix) + 347 base::ASCIIToUTF16(kServiceWorkerRegisterErrorPrefix) +
351 base::ASCIIToUTF16(kUserDeniedPermissionMessage))); 348 base::ASCIIToUTF16(kUserDeniedPermissionMessage)));
(...skipping 864 matching lines...) Expand 10 before | Expand all | Expand 10 after
1216 if (!handle) { 1213 if (!handle) {
1217 bad_message::ReceivedBadMessage(this, 1214 bad_message::ReceivedBadMessage(this,
1218 bad_message::SWDH_TERMINATE_BAD_HANDLE); 1215 bad_message::SWDH_TERMINATE_BAD_HANDLE);
1219 return; 1216 return;
1220 } 1217 }
1221 handle->version()->StopWorker( 1218 handle->version()->StopWorker(
1222 base::Bind(&ServiceWorkerUtils::NoOpStatusCallback)); 1219 base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
1223 } 1220 }
1224 1221
1225 } // namespace content 1222 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_dispatcher_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698