Move Service Worker %2f validation logic from browser into Blink (3)

content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_dispatcher_host.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/run_loop.h"
 #include "content/browser/browser_thread_impl.h"
@@ skipping 321 matching lines @@
                GURL("filesystem:https://www.example.com/temporary/"),
                GURL("filesystem:https://www.example.com/temporary/bar"));
   EXPECT_EQ(3, dispatcher_host_->bad_messages_received_count_);
 }
 
 TEST_F(ServiceWorkerDispatcherHostTest,
        Register_FileSystemScriptOrScopeShouldFail) {
   const int64 kProviderId = 99;  // Dummy value
   scoped_ptr<ServiceWorkerProviderHost> host(
       CreateServiceWorkerProviderHost(kProviderId));
+  host->SetDocumentUrl(GURL("https://www.example.com/"));
+  context()->AddProviderHost(host.Pass());
+
+  SendRegister(kProviderId, GURL("https://www.example.com/%2f"),
+               GURL("https://www.example.com/"));
+  EXPECT_EQ(1, dispatcher_host_->bad_messages_received_count_);
+
+  SendRegister(kProviderId, GURL("https://www.example.com/%2F"),
+               GURL("https://www.example.com/"));
+  EXPECT_EQ(2, dispatcher_host_->bad_messages_received_count_);
+
+  SendRegister(kProviderId, GURL("https://www.example.com/"),
+               GURL("https://www.example.com/%2f"));
+  EXPECT_EQ(3, dispatcher_host_->bad_messages_received_count_);
+
+  SendRegister(kProviderId, GURL("https://www.example.com/%5c"),
+               GURL("https://www.example.com/"));
+  EXPECT_EQ(4, dispatcher_host_->bad_messages_received_count_);
+
+  SendRegister(kProviderId, GURL("https://www.example.com/"),
+               GURL("https://www.example.com/%5c"));
+  EXPECT_EQ(5, dispatcher_host_->bad_messages_received_count_);
+
+  SendRegister(kProviderId, GURL("https://www.example.com/"),
+               GURL("https://www.example.com/%5C"));
+  EXPECT_EQ(6, dispatcher_host_->bad_messages_received_count_);
+}
+
+TEST_F(ServiceWorkerDispatcherHostTest, RegisterWithBadCharactersShouldFail) {

[falken, 2015/08/05 06:55:35]

These test names look reversed. 

[jeremyarcher, 2015/08/10 03:29:40]

Whoops! Had to stare at it for a second; PTAL.

[nhiroki, 2015/08/10 08:03:17]

I cannot see the updated patchset. Maybe you failed to upload it?

+  const int64 kProviderId = 99;  // Dummy value
+  scoped_ptr<ServiceWorkerProviderHost> host(
+      CreateServiceWorkerProviderHost(kProviderId));
   host->SetDocumentUrl(GURL("https://www.example.com/temporary/"));
   context()->AddProviderHost(host.Pass());
 
   SendRegister(kProviderId,
                GURL("filesystem:https://www.example.com/temporary/"),
                GURL("https://www.example.com/temporary/bar"));
   EXPECT_EQ(1, dispatcher_host_->bad_messages_received_count_);
 
   SendRegister(kProviderId,
                GURL("https://www.example.com/temporary/"),
@@ skipping 203 matching lines @@
 
   // To show the new dispatcher can operate, simulate provider creation. Since
   // the old dispatcher cleaned up the old provider host, the new one won't
   // complain.
   new_dispatcher_host->OnMessageReceived(ServiceWorkerHostMsg_ProviderCreated(
       kProviderId, MSG_ROUTING_NONE, SERVICE_WORKER_PROVIDER_FOR_WINDOW));
   EXPECT_EQ(0, new_dispatcher_host->bad_messages_received_count_);
 }
 
 }  // namespace content